https://bugzilla.redhat.com/show_bug.cgi?id=1835934 Pavol Zacik <pzacik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jskarvad@redhat.c | |om) --- Comment #27 from Pavol Zacik <pzacik@xxxxxxxxxx> --- Thanks for the update; new things still keep showing up: - The spec file has a duplicate `BuildRequires: desktop-file-utils`. - The rpttool shebang fix and `%doc README.rpttool` are now kind of pointless (but since rpttool will probably be reintroduced in the future, I don't see it as a big problem). - The solution of the missing runtime dependency problem suggested by Miro Hrončok in the last comment of [1] seems reasonable to me and works fine. - I see that your patch already got merged upstream. Could you bump to the newest version? This can wait until the final review, when the name conflict is resolved. - I noticed chirp also has locale files and tried playing with those; you should be able to install them using the following steps: 1. add `gettext` and `make` to BuildRequires 2. run `make -c chirp/locale` before %pyproject_wheel 3. install the locale files to %{buildroot} 4. run `%find_lang CHIRP` at the end of %install 5. append `-f CHIRP.lang` to %files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1835934 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201835934%23c27 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
