[Bug 2245476] Review Request: rust-gst-plugin-gif - GStreamer GIF plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2245476



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Artem from comment #2)
> This could be ignored? I've noticed this happens for all rust packages which
> generated by rust2rpm:
> 
> Issues:
> =======
> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice: /usr/share/cargo/registry/gst-plugin-
>   gif-0.11.0/LICENSE-APACHE
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_duplicate_files

Yes, this is a warning that can be ignored.
The resulting package contains the correct files and %doc files marked
appropriately.
I have confirmation from RPM upstream that this is an acceptable workaround for
limitations of RPM itself.

> ---
> 
> Why removing? If someone project will require it during build i'ts it's
> better to use unified PKG-CONFIG instead of distro packaged names. Or this
> scenario not possible with rust-gst-plugin-gif since nothing to link here?
> 
>   > # remove unnecessary pkgconfig file
>   > rm -v %{buildroot}/%{_libdir}/pkgconfig/gstgif.pc

Hm, we have removed these in the other gstreamer-rs plugins as well.
I don't think they are useful, since you can't link to this plugin, and there
are no generated header files, either.
As far as I can tell, the .pc file is just automatically generated by "cargo
cinstall", even if it's not needed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2245476

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245476%23c3
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux