https://bugzilla.redhat.com/show_bug.cgi?id=2240414 --- Comment #11 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- Ok so after looking into this further, I see some remaining issues: - please change the license field to "MIT AND BSD-3-Clause" to match SPDX style (capitalise AND) - I'd much prefer you use the URL https://github.com/ROCmSoftwarePlatform/rocBLAS as the upstream, as it makes it easier to find the clone-able code. I need to fix a few of the other ROCm packages to match. - There's a bunch of orphaned directories and we should make sure they're owned by a package as per the guidelines. I'd suggest either add them to the rocm-rpm-macros-modules package, or add a filesystem package to own these directories: /usr/lib64/rocm/gfx11 /usr/lib64/rocm/gfx11/lib /usr/lib64/rocm/gfx11/lib/cmake /usr/lib64/rocm/gfx10 /usr/lib64/rocm/gfx10/lib /usr/lib64/rocm/gfx10/lib/cmake /usr/lib64/rocm/gfx9 /usr/lib64/rocm/gfx9/lib /usr/lib64/rocm/gfx9/lib/cmake /usr/lib64/rocm/gfx8 /usr/lib64/rocm/gfx8/lib /usr/lib64/rocm/gfx8/lib/cmake I'd much rather we fix this before approving this package, or else we're run into orphaned directories. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2240414 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202240414%23c11 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
