https://bugzilla.redhat.com/show_bug.cgi?id=2235082 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(gui1ty@penguinpee | |.nl) | --- Comment #7 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Let me apologize upfront for being pedantic. But the package can still not be approved. (In reply to Robert-André Mauchin 🐧 from comment #6) > Seems I forgot to save my changes before uploading. Happens to the best of us. ;) > > => Some scripts appear to carry a different license. Please clarify. > > Added the one script that has a different one. I'm not sure which file you are referring to here, but it may not be of importance. See next... > Note that test data have false positive because they contains license texts. I see. Indeed, the files `licensecheck` stumbled upon are not shipped in the final package. So that issue is solved. > > solution is to make it require the main package. > > OK I'm not sure about your reply here. You didn't change the package to make the doc sub package require the main package. But the license files are included now when installing the main package or any sub package. So, that issue is solved as well. But... However, I just saw you generate HTML documentation using Sphinx. Sorry for not noticing earlier. In that case you would need to adopt the license specifier, because the Javascript files, Sphinx puts in there, carry their own license and you would need to add additional `Provides:`. See: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/thread/LLUAURXZVADATHK65HBPPBHKF4EM4UC3/ I think it's easiest to not generate HTML docs and drop the sub package or generate PDF docs instead. The latter usually requires a myriad of dependencies just for generating the PDFs. > > 3. Duplicate license files > > OK Ack One more thing I noticed in the latest version of the spec file, is your loop to remove shebangs: for lib in src/saneyaml.py; do sed '1{\@^#!/usr/bin/env python@d}' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done Isn't that convoluted? You were only required to remove the shebang from one file, e.g. `sed -i '/^#!.*python/d' src/saneyaml.py`. As I mentioned in one of the other reviews, this package would also benefit from using forge macros. But that is a matter of personal preference and not a requirement. Summing it up, the _only_ issue left to get this approved is the doc sub package as explained above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2235082 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235082%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
