https://bugzilla.redhat.com/show_bug.cgi?id=2243345 --- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two minor things: 1. > %if %{with check} > %check > %cargo_test > %endif Why is this scriptlet before %prep? That's quite unusual, it's usually between %install and %files / %changelog. 2. %{_prefix}/lib/bootc/00-defaults.toml This looks like a configuration file. /usr/lib/ is really not the correct location for this? It should be in either /usr/share/bootc/ (for package defaults) or in /etc/bootc/ (for custom system-wide settings). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2243345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243345%23c11 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
