https://bugzilla.redhat.com/show_bug.cgi?id=2244877 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Flags| |fedora-review? --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good to me, with some small issues: 1. > # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval > ExcludeArch: %{ix86} Please remove this. It will cause problems for any (noarch) Python packages that depend on python3-nh3 if they ever are unlucky and get scheduled to run on an i686 builder. 2. I would recommend to move this: License: MIT AND Apache-2.0 AND (MIT OR Apache-2.0) AND (Zlib OR Apache-2.0 OR MIT) # Full license breakdown in LICENSES.dependencies To the python3-nh3 subpackage, and keep the License tag of the "main" package as just MIT to document the license of nh3 itself. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244877 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244877%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
