https://bugzilla.redhat.com/show_bug.cgi?id=2245301 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > # Tests available only on Github > %if %{with check} > Source: https://github.com/marirs/%{crate}/archive/%{nparse_commit}/%{crate}-%{nparse_shortcommit}.tar.gz > %else > Source: %{crates_source} > %endif Sources should not be conditionalized like this. Also, Rust crates MUST use the sources from crates.io (i.e. %{crates_source}). If a published crate tarball doesn't ship sources for tests, just don't run those tests. You can control which kinds of tests are run by passing flags like "-- --lib", "-- --doc", or "-- --tests" to "%cargo_test". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2245301 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245301%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
