https://bugzilla.redhat.com/show_bug.cgi?id=2245151 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Quick comment: > # (MIT OR Apache-2.0) AND Unicode-DFS-2016 > # Apache-2.0 OR MIT > # MIT > # MIT OR Apache-2.0 > # Unlicense OR MIT > # LICENSE.dependencies contains a full license breakdown > License: MIT AND Unicode-DFS-2016 This is not correct according to the latest guidance from Red Hat Legal. It is not "valid" to subsume "OR" expressions like this. The correct expression would be: License: MIT AND Unicode-DFS-2016 AND (Apache-2.0 OR MIT) AND (Unlicense OR MIT) (At least "A OR B" and "B OR A" are equivalent, so you can just include one of them. I usually choose the one that sorts first alphabetically.) Other than that, package looks pretty good. === Quick tip: If you do not want to package the "library interface" (does not look like this is intended to be used via Rust API anyway), you could add this at the top of the spec file: %global __cargo_is_lib() 0 And remove all the "-devel" subpackages in the spec file. That would make the patch obsolete, since the files are no longer installed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2245151 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245151%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
