https://bugzilla.redhat.com/show_bug.cgi?id=2242971 --- Comment #23 from Davide Cavalca <davide@xxxxxxxxxxxx> --- I tried running fedora-review against it but there are too many warnings/errors to paste it here, so I'll attach it instead. Things of note: > Header files in -devel subpackage, if present. > Note: python3-torch : /usr/lib64/python3.12/site- > packages/torch/_inductor/codegen/cpp_prefix.h python3-torch : and so on (there's a lot of these) -- are these useful/appropriate to ship it in the main package, or should they be moved to a -devel package? > python3-torch.aarch64: E: zero-length /usr/lib64/python3.12/site-packages/torch/ao/quantization/backend_config/observation_type.py > python3-torch.aarch64: E: zero-length /usr/lib64/python3.12/site-packages/torch/cuda/error.py > python3-torch.aarch64: E: zero-length /usr/lib64/python3.12/site-packages/torch/include/ATen/cudnn/Exceptions.h These need double checking if they're actually supposed to be empty > python3-torch.aarch64: E: unused-direct-shlib-dependency /usr/lib64/python3.12/site-packages/torch/lib/libshm.so /usr/lib64/python3.12/site-packages/torch/lib/libtorch.so.2.1 and so on (there's a lot of these too), see https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency > python3-torch.aarch64: E: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/torch/lib/libshm.so _gfortran_stop_string (/usr/lib64/python3.12/site-packages/torch/lib/libtorch_cpu.so.2.1) and so on (there's a lot of these too), I'm actually not sure what this one means > python3-torch.aarch64: W: position-independent-executable-suggested /usr/lib64/python3.12/site-packages/torch/bin/torch_shm_manager Generally our build flags should be doing -fPIE/-fPIC by default, are they not getting passed properly? > python3-torch.aarch64: E: non-executable-script /usr/lib64/python3.12/site-packages/torch/_appdirs.py 644 /usr/bin/env python3 and so on (there's a lot of these too), these usually mean you need to strip the shebang from the files as they're not meant to be run directly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2242971 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242971%23c23 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
