https://bugzilla.redhat.com/show_bug.cgi?id=2243260 Erico Nunes <ernunes@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ernunes@xxxxxxxxx | |m) | --- Comment #9 from Erico Nunes <ernunes@xxxxxxxxxx> --- (In reply to Pavol Zacik from comment #7) > - I would add %doc to %files with at least ChangeLog and README. Fixed this in the latest spec. > - The Source link should use at least the %version macro instead of the > hardcoded version. That way, you won't need to update it with the new > version. Fixed in the latest spec. > - Once you update the package to the newest version, you can also include > signature verification into %prep [1]; the upstream releases signatures > since version 1.0.5 (look for xdriinfo-1.0.5.tar.gz.sig at [2]). Thanks for the note, I will keep that in mind for the followup bump. > One more thing: I would add a comment to the patch, explaining the situation > (i.e, that it has been included in a newer version) [1]. Also fixed in the latest spec. Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/enunes/mesa-demos2/fedora-rawhide-x86_64/06543797-xdriinfo/xdriinfo-1.0.4-1.fc40.src.rpm https://copr.fedorainfracloud.org/coprs/enunes/mesa-demos2/build/6543797/ Thanks for the review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2243260 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243260%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
