https://bugzilla.redhat.com/show_bug.cgi?id=2244677 Tim Semeijn <tim@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |tim@xxxxxxx --- Comment #2 from Tim Semeijn <tim@xxxxxxx> --- This is an unofficial review as I am not in the packager group yet. > mactelnet.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/mactelnet rpmlint error about not using setgroups or initgroups before calling setuid and setgid. This could be a security risk. Best would be to contact upstream to get this fixed. Furthermore the Version and Release in your spec need some changes. You seem to be using a custom Version number not aligned with the latest release from upstream [1]. I would recommend using the upstream version. Using the git snapshot in the Release field is deprecated [2] and best would be to apply this in the Version field [3]. [1] https://github.com/haakonnessjoen/MAC-Telnet/tags [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#traditional-versioning [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244677 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244677%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
