https://bugzilla.redhat.com/show_bug.cgi?id=2244644 --- Comment #10 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Daniel Berrangé from comment #9) > (In reply to Neal Gompa from comment #7) > > > %dir %{_datadir}/%{name} > > > %{_datadir}/%{name}/nouefi.txt > > > %{_datadir}/%{name}/bootstub.bin > > > > You could also simplify this to "%{_datadir}/%{name}/" > > I generally prefer to be explicit in these scenarios, so that if a file is > unexpectedly not installed by 'make', we fail the RPM build instead of > silently creating the RPM with missing files. Fine with me. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244644 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244644%23c10 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue