https://bugzilla.redhat.com/show_bug.cgi?id=2244644 --- Comment #3 from Daniel Berrangé <berrange@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #2) > Initial spec review: > > > # SPDX-License-Identifier: MIT-0 > > # SPDX-FileCopyrightText: 2023 Red Hat > > This is unnecessary, given the FPCA and current structure. You can keep it, > but it's also going to become wrong very quickly if other people touch the > spec file. Yep will remove. > > # No one is attaching GDB to a boot sector > > %global debug_package %{nil} > > You already made the package noarch, so this is not needed. Ok > > Release: 1 > > You need the DistTag. Ok > > Source: https://gitlab.com/berrange/byebyebios/-/archive/v%{version}/%{name}-v%{version}.tar.gz > > Url: https://gitlab.com/berrange/byebyebios > > You can de-dupe this like so: > > URL: https://gitlab.com/berrange/byebyebios > Source: %{url}/-/archive/v%{version}/%{name}-v%{version}.tar.gz Oh, yes, that's nice. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244644 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244644%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
