https://bugzilla.redhat.com/show_bug.cgi?id=1835934 Pavol Zacik <pzacik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jskarvad@redhat.c | |om) --- Comment #20 from Pavol Zacik <pzacik@xxxxxxxxxx> --- Python guidelines say that `pip install chirp` MUST install the same package or nothing [1], which is not the case here [2]. I understand that the rule did not exist when this package was first created. From the guidelines, it is not clear what the correct procedure is in the case of a retired package, but it may be one of the following: - rename the package, - ask for an exception, - resolve this with Python SIG or PyPI. When I run the chirp binary without arguments, it fails with the following traceback: ``` Traceback (most recent call last): File "/usr/bin/chirp", line 8, in <module> sys.exit(chirpmain()) ^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/chirp/wxui/__init__.py", line 65, in chirpmain import wx ModuleNotFoundError: No module named 'wx' ``` It seems the wXPython dependency is somehow not generated correctly from requirements.txt. Lastly, I would add at least %doc README.chirpc under %files; it seems useful. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity [2] https://pypi.org/project/chirp/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1835934 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201835934%23c20 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
