https://bugzilla.redhat.com/show_bug.cgi?id=2243093 --- Comment #13 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Probably worth adding a section on KDE applications to packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines The desktop file seems to have the correct format: https://0xacab.org/jvoisin/mat2/-/blob/master/dolphin/mat2.desktop?ref_type=heads Maybe the desktop-file validate tool needs to be updated? Desktop file has a reference to an icon which does not seem to be packaged: mat2.svg This is in the sources: https://0xacab.org/jvoisin/mat2/-/tree/master/data?ref_type=heads so maybe worth packaging it in the location indicated in the desktop file and requiring hicolor-icon-theme Can BuildRequires: python3-gobject BuildRequires: python3dist(mutagen) BuildRequires: python3dist(pycairo) be installed automatically as they are in setup.py? https://0xacab.org/jvoisin/mat2/-/blob/master/setup.py?ref_type=heads This means they are likely not needed in the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2243093 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243093%23c13 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
