https://bugzilla.redhat.com/show_bug.cgi?id=2244212 Jarek Prokop <jprokop@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |jprokop@xxxxxxxxxx --- Comment #1 from Jarek Prokop <jprokop@xxxxxxxxxx> --- Unofficial review. * I don't think `Conflicts: rubygem-faraday` makes sense with a regular Rubygem, as all the directories are namespaced with a version, therefore there should be no file conflicts, or other kind of conflicts, the packages rubygem-faraday and rubygem-faraday2 should be parallel installable without a problem. There also isn't provides(rubygem-faraday) = %{version} so even less chances for a conflict. (And not sure if the Fedora Packaging guide has any rules about this) * Test suite isn't running *at all*, that's not great, nor desired state. * There are also missing dependencies (maybe only rubygem-faraday-net_http?), that should definitely reach fedora before this package does, IOW a review request should exist for it and this ticket should depend on it. If you'd try to require any part rubygem-faraday2, it will fail without the dependency. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244212 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244212%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
