[Bug 2242971] Review Request: python-torch - PyTorch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2242971



--- Comment #11 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
(In reply to Tom Rix from comment #10)
> The autogenerated build requires says we are missing python-cmake and
> python-ninja.
> Are these packages in the works ?

Both https://pypi.org/project/cmake/ and https://pypi.org/project/ninja/ are
giant hacks to shove the corresponding executable inside binary wheels so that
they can be installed in virtualenvs using pip rather than relying on OS-level
installations. They don’t include importable Python modules. Since OS-level
installations are what we do best, the reasonable thing to do is to patch those
dependencies out (noting in a comment that the patch is downstream-only because
the dependencies do make sense for the way upstream builds wheels), and just
have:

BuildRequires:  cmake
BuildRequires:  ninja


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2242971

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242971%23c11
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux