https://bugzilla.redhat.com/show_bug.cgi?id=2243830 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Benson Muite from comment #2) > Comments: > a) Perhaps remove src/vhacds.egg-info directory in prep section It’s my understanding that this is a harmless but basically obsolete practice at this point. There certainly is no danger of shipping upstream egg-info metadata by accident in pyproject-rpm-macros based packages. If nothing else, they ship dist-info rather than egg-info. > b) Should upstream also carry a BSD license file? Strictly speaking, they probably should. The source distribution includes the necessary license text in the header itself, but the binary wheels include machine code compiled from the V-HACD header-only C++ library but don’t include the BSD license text. I opened: Add the V-HACD license to the LICENSE file https://github.com/trimesh/vhacdx/pull/3 I think it would be inappropriate for me to patch the license file downstream unless the PR is merged. Instead, I’ll alter the spec file to ship a copy of the license file from v-hacd-devel. It’s worth noting that few packages even bother to account for header-only libraries in their License expressions, and attempting to ship copies of their header-only dependencies’ license files is probably vanishingly rare. New Spec URL: https://music.fedorapeople.org/python-vhacdx.spec New SRPM URL: https://music.fedorapeople.org/python-vhacdx-0.0.4-1.fc38.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2243830 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243830%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
