[Bug 2242838] Review Request: squashfs-tools-ng - A new set of tools and libraries for working with SquashFS images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2242838



--- Comment #9 from David Trudgian <dave@xxxxxxxxxxxx> ---
Many thanks for the comments. Have amended and updated the spec / src.rpm
files:

Spec URL: https://dctrud.fedorapeople.org/squashfs-tools-ng.spec
SRPM URL:
https://dctrud.fedorapeople.org/squashfs-tools-ng-1.2.0-1.fc40.src.rpm

>> %dir %{_includedir}/sqfs
>> %{_includedir}/sqfs/*

> This can be simplified to one line: "%{_includedir}/sqfs/"

Done.

>> %license COPYING*
>> %{_libdir}/libsquashfs.so.1*

> Please split out the library into its own -libs subpackage and make the other subpackages require them.

Done... though I'm not certain that I've specified the dependencies properly
here? Is there a shorter way?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2242838

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242838%23c9
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux