https://bugzilla.redhat.com/show_bug.cgi?id=2242838 --- Comment #4 from David Trudgian <dave@xxxxxxxxxxxx> --- Many thanks for the review. Have amended and updated the spec / src.rpm files: Spec URL: https://dctrud.fedorapeople.org/squashfs-tools-ng.spec SRPM URL: https://dctrud.fedorapeople.org/squashfs-tools-ng-1.2.0-1.fc40.src.rpm > Issues: > ======= > - Devel subpackage does not own /usr/include/sqfs Added a %dir entry. > - License field does not include licenses of mentioned exceptions. See > https://github.com/AgentD/squashfs-tools-ng/blob/master/COPYING.md Added additional SPDX identifiers. > - Look into rpmlint error: > squashfs-tools-ng-static.x86_64: E: static-library-without-debuginfo > /usr/lib64/libsquashfs.a Not sure how to end up with a static library with debuginfo here, so I removed the static package. > - Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Moved unversioned link to -devel package. > - Dist tag is present. Is there a reason not to use %autorelease macro? Changes spec to use %autorelease and %autochangelog macros. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2242838 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242838%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
