https://bugzilla.redhat.com/show_bug.cgi?id=2243305 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ASSIGNED --- Comment #6 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- a) Thanks. Please add a comment in the spec file why the tests are disabled. b) If none of the tests can be run, or only a limited subset, please add a %check section with: %pyproject_check_import see: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests c) Setup.py contains: install_requires=["requests", "bcrypt", "python-gnupg", "pyopenssl", "aiohttp", "importlib-metad ata; python_version < '3.8'"] Maybe a patch can be applied to remove the restriction python_version < '3.8' current fedora releases use python 3.11 and 3.12 d) Can you remove %{?python_disable_dependency_generator} and the section: Requires: python3-bcrypt Requires: python3-gnupg Requires: python3-pyOpenSSL Requires: python3-requests Requires: python3-aiohttp Requires: python3-importlib-metadata as the Python Fedora rpm build tooling can likely do this e) Please leave status as assigned. Status is changed upon resolution to approve, disapprove or not continue for some other reason. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2243305 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243305%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
