https://bugzilla.redhat.com/show_bug.cgi?id=2243305 acrandom@xxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org) --- Comment #3 from acrandom@xxxxx --- (In reply to Benson Muite from comment #1) > Initial comments: > a) Please use SPDX license identifier > https://spdx.org/licenses/GPL-3.0-or-later.html > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/#_valid_license_short_names > b) Source URL should be in the form: > Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_git_tags > c) spec and srpm urls should b to raw files that fedora-review can download Not sure I understand b) given that I'm linking a release from GitHub and that's the only way it's possible. Plus I had made a submission last year with exactly the same URL format and from what I see nothing has changed in that regard. Regarding c), the spec is already linked as raw file, though I still need to find a way for the srpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2243305 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243305%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
