https://bugzilla.redhat.com/show_bug.cgi?id=2242449 Sandro Bonazzola <sbonazzo@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Sandro Bonazzola <sbonazzo@xxxxxxxxxx> --- (In reply to Milan Zamazal from comment #10) > (In reply to Sandro Bonazzola from comment #9) > > Bottom line, I have some doubts about the license field in the spec file due > > to the GPL-2 sources included in the crate. > > Those are example files not related to regular runs of vhost-device-scmi > (see > https://github.com/rust-vmm/vhost-device/tree/main/crates/vhost-device-scmi/ > kernel/iio-dummy). They are included only in the source package and as I > understand > https://docs.fedoraproject.org/en-US/legal/license-field/#_basic_policy, > they shouldn't be listed in License tag. Right. So, looks good to me. Approving. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2242449 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242449%23c11 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue