[Bug 2241002] Review Request: gnome-shell-extension-forge - Tiling and window manager for GNOME Shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2241002



--- Comment #6 from Carl George 🤠 <carl@xxxxxxxxxx> ---
> [!]: If the package is under multiple licenses, the licensing breakdown
>      must be documented in the spec.

This was an oversight on my part, I did the breakdown but didn't complete the
comment for the second license.  Fixed in the spec file now.

 # main source code: GPL-3.0-or-later
-# css/index.js (installed as css.js)
+# css/index.js (installed as css.js): MIT
 License:        GPL-3.0-or-later AND MIT


> [!]: The spec file handles locales properly.

The spec file itself does handle locales properly, but there is an upstream bug
with how one of the locales is named.


> gnome-shell-extension-forge.noarch: W: no-documentation

Fixed by including the upstream README.md file.


> gnome-shell-extension-forge.noarch: E: invalid-lc-messages-dir /usr/share/locale/pt-br/LC_MESSAGES/forge.mo
> gnome-shell-extension-forge.noarch: E: incorrect-locale-subdir /usr/share/locale/pt-br/LC_MESSAGES/forge.mo

I've sent upstream a fix to rename this locale, and included it as a patch in
the package.

https://github.com/forge-ext/forge/pull/296


Spec URL:
https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/06514681-gnome-shell-extension-forge/gnome-shell-extension-forge.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/06514681-gnome-shell-extension-forge/gnome-shell-extension-forge-75-1.fc40.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2241002

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241002%23c6
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux