https://bugzilla.redhat.com/show_bug.cgi?id=2242971 --- Comment #3 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Notes from a first pass: - URL should be https://pytorch.org/, define %forgeurl or something like that for the github repo - please add a comment for each patch documenting what it does, and ideally a link to an upstream submission for it, or a note that it's internal only to Fedora and why - why are we statically linking blas? - you can drop the %{?python_provide:%python_provide python3-%{pypi_name}} it's not needed anymore - please use the pyproject macros instead of the deprecated python build macros; this should also allow you to drop all the Requires for the subpackages as they'll be autogenerated - use %{_includedir} instead of hardcoding /usr/include in %prep; also consider symlinking instead of coyping to make it more explicit where these come from - the thirdy_party stuff we're not removing needs to be declared as Provides: bundled() and taken into account in the License field - you shouldn't need to export CC and export CXX, %set_build_flags is called by default these days and does that for you -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2242971 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242971%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
