Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: audit https://bugzilla.redhat.com/show_bug.cgi?id=225292 ------- Additional Comments From sgrubb@xxxxxxxxxx 2008-01-11 15:46 EST ------- BTW, I use essentially the same spec file for upstream, RHEL, and Fedora. I don't like making changes for one that affects another since the audit system is under heavy development. If it were an older stable package, I wouldn't care so much. #1 fixed, #2 fixed but I like the shorter version better...why else have an url? #3 its a reminder to get it working at some point - added a comment, #4 sometimes people like to make a utility that runs early or from busybox. I'd rather delete it in a few more weeks. #5 it already was that way, #6 will look into it another day, patches are welcome, #7 that was put there because it was required. There was a bz opened that this was the fix for so I can't get rid of it, #8 a) af_unix must be that way due to a mistake that must be overwritten. I'll change that another time. b) coreutils has to be there. c) I don't know a better way to do this patches welcome please test on x86_64, though. d) logrotate is the enemy of audit. Audit must do its own rotation for security purposes. e) those upgrade commands are for audit 1.0.x systems. f) where is this done in the spec file? I don't see any symlinking of consolehelper. Then again, consolehelper had better be in /usr/bin and not some relative directory. audit-1.6.5-3 has the changes from this review in it. When you see if finish going through koji successfully, please feel free to look it over. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review