https://bugzilla.redhat.com/show_bug.cgi?id=1654664 --- Comment #10 from Petr Pisar <ppisar@xxxxxxxxxx> --- FIX: The Source1 "bsd" file is an ugly HTML file, including a JavaScript code. That pieces of the file themselves are covered with CC-BY-4.0 license. Either add "CC-BY-4.0" to the License tag, or extract the BSD license text as a plain text without additional baggage. No XS code, noarch BuildArch is Ok. TODO: Add '>= 6.76' to 'BuildRequiers: perl(ExtUtils::MakeMaker)' for NO_PACKLIST=1 NO_PERLLOCAL=1 arguments. All tests pass. Ok. $ rpmlint perl-Authen-U2F.spec ../SRPMS/perl-Authen-U2F-0.003-3.fc40.src.rpm ../RPMS/noarch/perl-Authen-U2F-0.003-3.fc40.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 ========= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Authen-U2F-0.003-3.fc40.noarch.rpm drwxr-xr-x 2 root root 0 Oct 4 02:00 /usr/share/doc/perl-Authen-U2F -rw-r--r-- 1 root root 337 Oct 4 2017 /usr/share/doc/perl-Authen-U2F/Changes -rw-r--r-- 1 root root 352 Oct 4 2017 /usr/share/doc/perl-Authen-U2F/README drwxr-xr-x 2 root root 0 Oct 4 02:00 /usr/share/licenses/perl-Authen-U2F -rw-r--r-- 1 root root 18352 Oct 4 2017 /usr/share/licenses/perl-Authen-U2F/LICENSE -rw-r--r-- 1 root root 50325 Oct 4 02:00 /usr/share/licenses/perl-Authen-U2F/bsd -rw-r--r-- 1 root root 2767 Oct 4 02:00 /usr/share/man/man3/Authen::U2F.3pm.gz drwxr-xr-x 2 root root 0 Oct 4 02:00 /usr/share/perl5/vendor_perl/Authen -rw-r--r-- 1 root root 11071 Oct 4 2017 /usr/share/perl5/vendor_perl/Authen/U2F.pm The file layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Authen-U2F-0.003-3.fc40.noarch.rpm | sort -f | uniq -c 1 perl(Carp) 1 perl(Crypt::OpenSSL::X509) >= 1.806 1 perl(Crypt::PK::ECC) 1 perl(CryptX) >= 0.034 1 perl(Digest::SHA) 1 perl(Exporter::Tiny) 1 perl(JSON) 1 perl(Math::Random::Secure) 1 perl(MIME::Base64) >= 3.11 1 perl(namespace::autoclean) 1 perl(parent) 1 perl(strict) 1 perl(Try::Tiny) 1 perl(Type::Params) 1 perl(Types::Standard) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Authen-U2F-0.003-3.fc40.noarch.rpm | sort -f | uniq -c 1 perl(Authen::U2F) = 0.003 1 perl-Authen-U2F = 0.003-3.fc40 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Authen-U2F-0.003-3.fc40.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 40 (https://koji.fedoraproject.org/koji/taskinfo?taskID=107273151). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' item, consider fixing the 'TODO' item, and provide a new spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1654664 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201654664%23c10 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue