https://bugzilla.redhat.com/show_bug.cgi?id=2239242 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx --- Comment #1 from Petr Menšík <pemensik@xxxxxxxxxx> --- It is quite unusual to have a package without upstream URL. Why is this package a separate source if it does not have any upstream repository? Wouldn't it make sense to create fedora-specific subpackage to any package it is related to? It does not explain what IMA stands for, which packages use it and for what exactly. I think at least README.md with a bit more descriptive text how and for what this is used would be useful. Especially with some links to more detailed page. Would a good candidate be [1]? I think all files installed into /etc should have %config(noreplace) added to them, unless very special case. The spec lacks %prep section, where %autosetup should be present. I think it expands it into long description, which should not be done. I would say if this package does not have any upstream, it should have version 0 only. Release incrementals should be enough, until some upstream archive is used with any version assigned to it. 1. https://sourceforge.net/p/linux-ima/wiki/Home/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2239242 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202239242%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
