https://bugzilla.redhat.com/show_bug.cgi?id=2239811 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #13 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #12) > Thanks for the reviews, folks. > > Yeh, quite a few things can be done to modernise the code. It's basically > something that was written years ago (by someone else) that we've now > started to re-maintain. You'll see that I've done the basics of adding tests > and all that but we haven't touched the original code much yet. I think the > way to go here would be to file issues for what we've found here so I can > work on them for the next release. That way we don't block this review, and > it'll give me time to work on things. We've got a few urgent deadlines > coming up and I'm still trying to work on vxl and the other packages, so > this will take a couple of weeks to get to. > > How does that sound? Sounds good to me. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2239811 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202239811%23c13 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
