Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: tsclient https://bugzilla.redhat.com/show_bug.cgi?id=226504 ------- Additional Comments From tyler.l.owen@xxxxxxxxx 2008-01-11 13:21 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. FIX - Spec has consistant macro usage. - Do not use %makeinstall macro OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - Package needs ExcludeArch OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package is relocatable and has a reason to be. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. FIX - Package is a GUI app and has a .desktop file - Vendor should be set to fedora instead of tsclient - remove the " --add-category Utility " entry OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. FIX - No rpmlint output. SRPM: tsclient.src: W: mixed-use-of-spaces-and-tabs (spaces: line 50, tab: line 53) RPM: tsclient.i386: W: incoherent-version-in-changelog 0.150.5 0.150-5.fc8 tsclient.i386: E: incorrect-locale-el /usr/share/locale/gr/LC_MESSAGES/tsclient.mo - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version FIX - check for outstanding bugs on package. (For core merge reviews) 242315 - remove the Utility category (see above) Issues: 1. Do not use %makeinstall macro 2. Fix vendor in desktop file, should be fedora 3. Fix bug 242315 4. rpmlint not quiet rpm: Changelog should use - instead of . to denote release Need to notify upstream that the Greek local has changed from el to gr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review