Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NNTPGrab - Usenet download program https://bugzilla.redhat.com/show_bug.cgi?id=427034 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-11 11:12 EST ------- For general packaging guidelines, please refer to http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines For 0.2.1-2: * disttag - Please consider to use %{?dist} tag. http://fedoraproject.org/wiki/Packaging/DistTag * URL - Perhaps URL contains some typo :) * Seemingly unneeded Provides - Why do you want to make -plugins subpackage have "Provides: nntpgrab-plugin-nntp" or so? - Also, "Obsoletes: nntpgrab-plugin-nntp" seems unneeded as perhaps Fedora has never had nntpgrab-plugin-nntp rpm. * Dependency between subpackage - -devel subpackage should have "Requires: %{name}-core = %{version}-%{release}" * %configure - %configure should be moved to %build. * Vendor name of desktop file - Usually the vendor id of desktop file should be "fedora". Do you want to have desktop file named "NNTPGrab-nntpgrab.desktop"? * libtool .la file <-> .so symlink - libtool .la file should be removed unless needed. Instead the symlink %{_libdir}/libnntpgrab.so should _not_ be removed and this symlink should be included in -devel subpackage. * defattr - We now recommend %defattr(-,root,root,-) * Directory ownership issue - %{_includedir}/nntpgrab is not owned by any packages. * Dependency for -devel pacakage - %_libdir/pkgconfig/nntpgrab.pc contains the line: -------------------------------------------------------- 9 Requires: glib-2.0 -------------------------------------------------------- Also %_includedir/nntpgrab/nntpgrab.h contains -------------------------------------------------------- 22 #include <glib.h> -------------------------------------------------------- This means that -devel subpackage should have "Requires: glib2-devel". ? plugins - By the way, if all files in -plugins package under %_libdir directory are only used as plugins called by only dlopen, is it possible - to move all plugins to some unique directory only used by nntpgrab, for example %_libdir/nntpgrab - and "rename" (not symlink) libnntpgrab_plugin_nntp.so.0.0.0 to libnntpgrab_plugin_nntp.so, for example (as dlopen'ed file name is libnntpgrab_plugin_nntp.so) (not a blocker) ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review