Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package review: cronie https://bugzilla.redhat.com/show_bug.cgi?id=428007 ------- Additional Comments From pertusus@xxxxxxx 2008-01-11 10:54 EST ------- (In reply to comment #14) > (In reply to comment #12) > > I have some comments on upstream. > > * I think it would be better to isolate crond.pam, crond.sysconfig > > vixie-cron.init (renamed cronie.init) in something like a contrib > > directory and not install them, they are platform specific. > > IMO contrib/ directories are usually for stuff contributors submit but upstream > doesn't plan to support (which clearly is not the case here). I'd add e.g. > --with-pam and --with-sysvinit to configure.ac and install the files if the user > wants it. Marcela, shout if you want help with that. Yes, that would be another possibility. And indeed contrib is a bad name for a directory holding those files. Maybe data or utils? In any case they shouldn't be installed in the default case since they are too platform dependent. > > * The fact that vixie-cron.init and crond.sysconfig appear in the > > distribution is complete magic to me > > What do you mean? I may have missed something but they are not in any variable in Makefile.am nor in EXTRA_DIST... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review