https://bugzilla.redhat.com/show_bug.cgi?id=2242365 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package looks good to me, with one exception: The changes in the manually written patch are a bit confusing to me, and look like there's been a mistake. 1. Removing "max-performance-safe" from the "default" features should not be necessary? The "max-performance" feature is dropped, but not "max-performance-safe" (maybe this happened by mistaking the names?), so "max-performance-safe" should remain part of the "default" feature set. 2. Additionally, I think "max-performance" feature could be kept as well. I assume that you dropped it because "gix-features/zlib-ng" is not available? I would keep "max-performance" feature and just remove the "gix-features/zlib-ng" feature from it, which should work just as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2242365 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242365%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
