https://bugzilla.redhat.com/show_bug.cgi?id=2242199 Aaron Rainbolt <arraybolt3@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arraybolt3@xxxxxxxxx --- Comment #2 from Aaron Rainbolt <arraybolt3@xxxxxxxxx> --- This is not an official review, and is very far from thorough. I just wanted to get some skills doing reviews and thought I could help out. * This package is still using an old-style license abbreviation in the License field. This should be updated. "ASL 2.0" -> "Apache-2.0" * There's a possible redundancy in the spec file: > Version: 0.14.1 > %global tag 0.14.1 I think you can drop "%global tag" - it has the exact same value as the Version field, and according to https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/, "You first specify either a Version, tag or commit in the header." So I think Version will work in lieu of "%global tag". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2242199 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242199%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
