https://bugzilla.redhat.com/show_bug.cgi?id=2228155 --- Comment #18 from Steve Cossette <farchord@xxxxxxxxx> --- Alright, some additional suggestions before I go with the final check: 1- The server subpackage should require exactly the same version as the main package. Similar to what you did with the devel subpackage. But you should also use the %{_isa} macro so that it works properly across different arches. For example: Requires: %{name} = %{version}-%{release} Should be: Requires: %{name}%{?_isa} = %{version}-%{release} https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_specific_dependencies 2- %{_libdir}/libdsocks.so should be moved to the devel package Once that's done, I'll do a final check and then I think I'll be ready to approve this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2228155 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228155%23c18 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
