https://bugzilla.redhat.com/show_bug.cgi?id=2241418 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |pemensik@xxxxxxxxxx --- Comment #1 from Petr Menšík <pemensik@xxxxxxxxxx> --- Please use %make_build and %make_install instead %__make custom definitions if possible. It seems empty %_sysconfdir/%name.d should be created and shipped, that directory is referenced by example configuration. Why is not just %_sysconfdir/smcroute.conf shipped with %config(noreplace) attribute? Why is shipped just example copy, but in /etc directory? If that example is example only and :should be copied, then it belongs to %doc where it were installed. If it should be modified by administrator, then it must have %config(noreplace) to protect changes on upgrades. Otherwise it looks fine and ready. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241418 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241418%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
