https://bugzilla.redhat.com/show_bug.cgi?id=2240414 --- Comment #2 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- So I'm not totally opposed to the idea of splitting up the SO libs... but I'm a bit concerned with the logic in %post. My gut says we shouldn't copy, but use symlinks instead, but if you're going to use symlinks, I would suggest "alternatives". It's not 100% a traditional use for alternatives, but it at least allows the user/system maintainer to switch easily if the detect logic doesn't work. It also reduces some possible packaging pitfalls. I also suggest to have a bunch of rocblas subpackages. E.g rocblas-gfx11, rocblas-gfx10, etc, with a metapackage of "rocblas" that just pulls them all in with the detection logic. This allows easier selection by the user installing the packages. My gut also says to default to gfx11, but this is completely subjective and I have no good reason to feel this way. Last point, please update to 5.7, I just pushed the update to hip this morning. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2240414 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202240414%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
