[Bug 2241062] Review Request: blake3 - Official C implementation of the BLAKE3 cryptographic hash function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2241062



--- Comment #4 from Christoph Erhardt <fedora@xxxxxxxxxxx> ---
(In reply to Benson Muite from comment #3)
> a) Use %global instead of %define
I have added an explanatory comment that these macros are used only locally
within `%check`. That's why I refrained from making them global.

> c) The sonames are not consistent,
> libblake3.so.0
> libblake3.so.1.5.0
> Would have expected the first one to be
> libblake3.so.1
> See https://github.com/BLAKE3-team/BLAKE3/pull/355
I have added your patch to the `.spec` file.

> d) There seem to be problems with builds on i686 and x84_64:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=107011376
Okay, this looks strange. AddressSanitizer reports a segfault within the
AVX-512 code.

Using the power of Podman, I can reproduce the segfault ...
* on an AVX-512-capable machine under Fedora 37, 38, 39 and Rawhide.
* on an AVX-512-capable machine under Ubuntu 23.04 and 23.10.
However, I cannot reproduce it ...
* on an AVX-512-capable machine under Ubuntu 22.04.
* on a machine that does not support AVX-512.

I'm wondering whether this might be a regression in AddressSanitizer.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2241062

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241062%23c4
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux