https://bugzilla.redhat.com/show_bug.cgi?id=2241780 --- Comment #4 from blinxen <h-k-81@xxxxxxxxxxx> --- Here is my initial review: * Please change the license to a valid SPDX identifier. In this case it should be `GPL-3.0-only`. * According to https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_packaging, you must add `gcc`, `gcc-c++` or `clang` to `BuildRequires`. * Please remove "(Unretirement review)" from the bug description. * The description includes a link to http://masterpasswordapp.com, which redirects to https://spectre.app/. Please update the description. * According to https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage the appdata.xml file should be located in "%{buildroot}%{_metainfodir}/". * Not really an issue, but the marco `commit` should probably be renamed to git_tag or tag as it essentially a git tag and not a commit hash. * Also not an issue, but I would change $RPM_BUILD_ROOT to %{buildroot}. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241780 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241780%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
