https://bugzilla.redhat.com/show_bug.cgi?id=2232203 --- Comment #7 from Kevin Fenzi <kevin@xxxxxxxxx> --- Sorry for the delay here... Many issues taken care of, thanks! Whats left: 1. Non blockery, but might submit these upstream if they don't already have them in progress? INFO: No upstream for (Source10): receptor_tmp.conf INFO: No upstream for (Source9): receptor.logrotate INFO: No upstream for (Source8): receptor.sysusers INFO: No upstream for (Source7): receptor.pp INFO: No upstream for (Source6): receptor.conf.example INFO: No upstream for (Source5): receptor.conf INFO: No upstream for (Source4): receptor@.service INFO: No upstream for (Source3): receptor.service 2. Please own /etc/receptor directory You still need to do this. ;) In files you need to list /etc/receptor as a %dir, or just list it and don't list the 2 config files in it. 3. Can different versions of the 3 packages all operate ok? If not, it might be safer to require the exact version on all of them. ie, Requires: %{name}%{?_isa} = %{version}-%{release}, instead of just requiring the name. So, should we require the exact same versions of the subpackages, or not? ie, if you have: python3-receptor-python-worker-1.4.1-1.fc40.x86_64.rpm receptor-1.4.1-1.fc40.x86_64.rpm receptorctl-1.4.1-1.fc40.x86_64.rpm all installed, great, but then 1.5.0 comes out and you just upgrade python3-receptor-python-worker-1.5.0-1.fc40.x86_64.rpm will that break the other two packages? I suspect strongly so. If so, then we need to require the exact same version on all of them to make sure rpm/dnf won't upgrade just one of them and break all of them. 4. receptor.x86_64: W: unused-direct-shlib-dependency /usr/bin/receptor /lib64/libresolv.so.2 Should this really be linked with -lresolv? Did you find anything out about this one? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2232203 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202232203%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
