[Bug 2240906] Review Request: xss-lock - Use external locker as X screen saver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2240906



--- Comment #3 from Jani Juhani Sinervo <jani@xxxxxxxxxx> ---
> - I just want to make sure you know what you're getting into.  I count 1
>   deprecation warning from glib2 when building, 4 open pull requests, and 18
>   open issues on bitbucket.  Since upstream appears to be inactive, you're
>   putting yourself on the hook to address any of those issues that affect
>   Fedora users.  Are you sure you want to sign up for that?

I understand what I'm getting myself into here. I'll probably start a fork for
the project at some point,
but before that I'd like to get the current project version up to Fedora again
just so it can be used at all.

> - What is the rationale for the python3-docutils BR?  It doesn't seem to be
>   used in the build.

Honestly? No idea. It must have just been left there from the previous
maintainer. Removed.

> - Note the rpmlint warnings below: strange-permission and
>   mixed-use-of-spaces-and-tabs

Tabs were fixed. As for the permissions problem in the SRMP, I have no idea how
that happened.
Seems that `fedpkg mockbuild` was being a tad screwy. Anyway, fixed.

Spec URL: https://sham1.xyz/files/rpm-review/xss-lock/xss-lock.spec
SRPM URL:
https://sham1.xyz/files/rpm-review/xss-lock/xss-lock-0.3.0^20140302git1e158fb20108-1.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2240906

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202240906%23c3
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux