https://bugzilla.redhat.com/show_bug.cgi?id=2218338 Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |zonexpertconsulting@outlook | |.com --- Comment #6 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> --- Wow, you've been waiting awhile for this one. There are elements of this specfile I am not familiar with (i.e. lang files), but I'll get up to speed as we progress. I haven't run fedora-review yet. For starters let's discuss rpmlint, since it was rather noisy: $ rpmlint *.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 skribilo.noarch: E: zero-length /usr/share/doc/skribilo/ChangeLog skribilo.noarch: W: only-non-binary-in-usr-lib skribilo.noarch: E: noarch-with-lib64 skribilo.noarch: W: no-manual-page-for-binary skribilo-config skribilo.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) skribilo.spec:147: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/diff.go skribilo.spec:148: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}.go skribilo.spec:149: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name} skribilo.spec:150: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/*.go skribilo.spec:151: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/biblio skribilo.spec:152: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/biblio/*.go skribilo.spec:153: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/documentation skribilo.spec:154: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/documentation/*.go skribilo.spec:155: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/engine skribilo.spec:156: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/engine/*.go skribilo.spec:157: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package skribilo.spec:158: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/*.go skribilo.spec:159: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/eq skribilo.spec:160: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/eq/*.go skribilo.spec:161: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/pie skribilo.spec:162: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/pie/*.go skribilo.spec:163: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/slide skribilo.spec:164: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/slide/*.go skribilo.spec:165: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/reader skribilo.spec:166: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/reader/*.go skribilo.spec:167: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/source skribilo.spec:168: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/source/*.go skribilo.spec:169: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/utils skribilo.spec:170: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/utils/*.go skribilo.noarch: W: file-not-utf8 /usr/share/doc/skribilo/ChangeLog.Skribe skribilo.noarch: W: file-not-utf8 /usr/share/man/man1/skribilo.1.gz skribilo.noarch: W: file-not-in-%lang /usr/share/locale/da/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/fur/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/sr/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/skribilo.mo skribilo.noarch: W: devel-file-in-non-devel-package /usr/bin/skribilo-config skribilo.noarch: E: description-line-too-long Last but not least, Skribilo can be thought of as a complete document programming skribilo.noarch: E: description-line-too-long framework for the Scheme programming language that may be used to automate a variety skribilo.noarch: E: description-line-too-long of document generation tasks. Technically, the Skribilo language/API is an embedded skribilo.noarch: E: description-line-too-long domain-specific language (EDSL), implemented via so-called “deep embedding”. Skribilo skribilo.src: E: description-line-too-long Last but not least, Skribilo can be thought of as a complete document programming skribilo.src: E: description-line-too-long framework for the Scheme programming language that may be used to automate a variety skribilo.src: E: description-line-too-long of document generation tasks. Technically, the Skribilo language/API is an embedded skribilo.src: E: description-line-too-long domain-specific language (EDSL), implemented via so-called “deep embedding”. Skribilo skribilo.noarch: W: dangling-relative-symlink /usr/share/info/bsd.png.gz ../doc/skribilo/bsd.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/document-toolchain.png.gz ../doc/skribilo/document-toolchain.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/eq-disponibilite.png.gz ../doc/skribilo/eq-disponibilite.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l-simplified.png.gz ../doc/skribilo/eq-limit-b-over-l-simplified.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l.png.gz ../doc/skribilo/eq-limit-b-over-l.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/linux.png.gz ../doc/skribilo/linux.png.gz 2 packages and 0 specfiles checked; 10 errors, 45 warnings, 10 badness; has taken 0.4 s ============================ rpmlint session ends ============================ TO-DO: - please remove the zerolength ChangeLog or consider symlinking it with ChangeLog.Skribe - I know rpmlint is nitpicking, but please use either spaces or tabs in the specfile, not both - please shorten the length of each line in the description such that each is less than 80 characters - While skribilo itself is just a shell script and hence, not arch dependent, the .go files generated by guile are architecture dependent. We need to do something about this. Perhaps the simplest thing to do would be to remove the noarch flag in the specfile. - Rpmlint is complaining about the lang files placed under /usr/share/locale. This implies we should be doing something more than just placing files there. I'm not sure yet what the answer is to this, but I did find mention of this %find_lang macro: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_why_do_we_need_to_use_find_lang Comments: I haven't yet verified the relative symlinks rpmlint is complaining about, but I suspect they are correct. The rest of the warnings can be ignored. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218338 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218338%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
