https://bugzilla.redhat.com/show_bug.cgi?id=2237325 --- Comment #3 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- - automake already requires autoconf, so that's redundant done - consider separating the executables into a -tools subpackage done - the summary field for -devel subpackage seems wrong? Thanks. Fixed. - as the patch is already merged upstream, consider using forge macros and specifying the commit https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control Left it for now. Can drop it on the next release. - use `autoreconf -i` instead of supplied autogen.sh Done. - use plain `%configure` without args and provide the static library in -static, if possible https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries Guidelines suggest it is preferable not to include static libraries unless there is a good reason to do so. So, typically do not package them unless there is a dependency that needs the static library. spec: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06479780-libtexprintf/libtexprintf.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06479780-libtexprintf/libtexprintf-1.25-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2237325 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202237325%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
