[Bug 2241171] Review Request: python-pyxdameraulevenshtein - Damerau-Levenshtein (DL) edit distance algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2241171



--- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thank you for the review!

(In reply to Benson Muite from comment #1)
> Comments:
> a) Perhaps change permissions of spec file and line end encoding of
> CHANGES.md upon import.

The warning

  python-pyxdameraulevenshtein.src: W: strange-permission
python-pyxdameraulevenshtein.spec 600

is an rpmautospec bug that appears on every package that uses it. It looks like
it was fixed, but the fix was not yet released. See
https://pagure.io/fedora-infra/rpmautospec/issue/301 for details. Fortunately,
the “strange” permissions are harmless.

The “DOS-style” CRLF line terminators in CHANGES.md are indeed something I
missed, and I will fix them on import.

> b) Approved
> c) May wish to also examine https://pypi.org/project/editdistance/

There are a lot of implementations of this family of algorithms. The goal of
packaging this one is to provide all of the optional dependencies of
https://src.fedoraproject.org/rpms/python-textdistance, which in turn is a
dependency for the Spyder IDE. We don’t strictly need the corresponding
textdistance “extras” for Spyder, but it’s nice to have a complete package.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2241171

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241171%23c2
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux