https://bugzilla.redhat.com/show_bug.cgi?id=2241553 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Quick comments before I do a full review: > I'm slightly unsure how to best handle the aperture crate. It's developed > in-tree, and referenced as 'path = "./aperture"' in Cargo.toml. Perhaps it > would make sense to package it separately, but for now I've gone with > including it in the same rpm. Opinions welcome. I see the "aperture" crate is also published separately: https://crates.io/crates/aperture There are two options for handling this case: - use the version bundled in snapshot - package from crates.io, replace "path" dependency with a "normal" dependency So long as snapshot is the only user of the "aperture" crate, I think both are OK. But as soon as more things start depending on it, I would try to unbundle it. ------------------------------------------------------------ > %global tarball_version %%(echo %{version} | tr '~' '.') I think you could replace this with "%{version_no_tilde .}": """ $ rpm --define "version 45.0~rc1" -E "%{version_no_tilde .}" 45.0.rc1 """ ------------------------------------------------------------ What is the license of snapshot itself? It might be good to add either SourceLicense: GPL-3.0-or-later or a comment like # snapshot: GPL-3.0-or-later # crate dependencies: # <... list crate licenses> ------------------------------------------------------------ > Provides: bundled(rust-aperture) = 0.3.1 This should be in a slightly different format to match other Provides for Rust crates: Provides: bundled(crate(aperture)) = 0.3.1 ------------------------------------------------------------ You mentioned on Matrix that you needed gstreamer1-plugin-gtk4 for this application, but I don't see it mentioned in the spec file? Should it be a dependency (Requires: gstreamer1-plugin-gtk4), or is it somehow added automatically? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241553 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241553%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
