https://bugzilla.redhat.com/show_bug.cgi?id=2241414 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > %global pkg_version 1.9.0 This seems redundant to %version? Do you need this? > BuildRequires: cmake-data This is not needed, as cmake-data is pulled in by cmake > BuildRequires: libicu-devel icu Please avoid putting multiple dependencies on a single line, as that makes it difficult to diff later when changes happen. > Patch0: cmake-perl-bindings.diff > Patch1: migrate-to-setuptools.diff While not required, stylistically usually these lines are right below Source lines. Feel free to choose to move it or keep as-is. > %setup -q > > %patch -P0 -p1 -b .perl > %patch -P1 -p1 This can be replaced with "%autosetup -p1" > find %{buildroot} -type f -name "*.la" -delete -print Does this CMake build even produce libtool archives? If not, this can be dropped. > %doc AUTHORS COPYING ChangeLog LICENSE NEWS README "COPYING" and "LICENSE" need to be listed as "%license", like so: %license COPYING LICENSE > # Re-enable after upstream includes it with CMake builds > %config(noreplace) %{_sysconfdir}/sword.conf This comment makes no sense? What's it for? > %{_datadir}/sword Please put a trailing slash here to ensure RPM knows to track it as a directory. > %{perl_vendorarch}/* This glob is too greedy and needs to be scoped tighter, similar to the Python one. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2241414 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241414%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
