https://bugzilla.redhat.com/show_bug.cgi?id=2235080 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |gui1ty@xxxxxxxxxxxxx CC| |gui1ty@xxxxxxxxxxxxx --- Comment #1 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Looking at the spec file: %global pypi_name pymaven-patch %global pypi_name_with_underscore %(echo "%{pypi_name}" | sed "s/-/_/g") %global github_name pymaven This seems over engineered. Here you could really benefit from the forge macros. I'll supply a patch for inspiration. You are not using all the macros consistently (e.g.: `%pyproject_save_files pymaven`). Personally, I'd do away with the macros and just spell it out. Makes the spec file easier to read. A comment on why `export PBR_VERSION=%{version}` is needed would be appreciated. It helps others understanding the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2235080 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235080%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
