https://bugzilla.redhat.com/show_bug.cgi?id=2235084 --- Comment #2 from Sandro <gui1ty@xxxxxxxxxxxxx> --- A few questions/remarks looking at the spec file. Formal review is coming up. 1. PyPI vs. GitHub You are getting the source from GitHub. Is the PyPI tarball not usable? Since pulling from GitHub, did you consider using forge macros? It makes the Source URL more readable and saves you from having to construct it yourself. 2. Documenting changes In %prep you modify pyproject.toml and setup.cfg. Could you add a comment explaining why this is necessary. For the first edit there might be a cleaner, more readable solution. Or you could do without it completely using the PyPI source which has the version set. 3. Duplicate license files All license files are defined in `license_files` in `setup.cfg`. That means `%pyproject_save_files` treats them as such and marks them as license files. Use `rpm -q --licensefiles -p $RPM` to verify. Long story short, you can drop `%license`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2235084 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235084%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
