https://bugzilla.redhat.com/show_bug.cgi?id=2241062 --- Comment #2 from Christoph Erhardt <fedora@xxxxxxxxxxx> --- Thanks a lot for the prompt sanity check! (In reply to Benson Muite from comment #1) > Initial comment is that CC0-1.0 is not an allowed license for code. May wish > to just use Apache-2.0 > > CC-PDDC is allowed though: > https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ Thanks, I missed that. I suggest we just stick to Apache-2.0 then. > The rust crate offers a variety of build options: > https://src.fedoraproject.org/rpms/rust-blake3/blob/rawhide/f/rust-blake3. > spec Hmm, so should we rather augment that SPEC file instead of adding a separate one for the C library? > Fedora typically allows use of SSE and AVX2 intrinsics, though maybe an > additional package with AVX512 > might be helpful for some users. The library dynamically selects the best SIMD variant based on the capabilities of the CPU it is being run on - see https://github.com/BLAKE3-team/BLAKE3/blob/master/c/blake3_dispatch.c. Does that make it okay to include the AVX512 code path in the default build? > Can the test be run? > https://github.com/BLAKE3-team/BLAKE3/blob/master/c/test.py Actually, that script is already called indirectly via `Makefile.testing`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241062 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241062%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
