https://bugzilla.redhat.com/show_bug.cgi?id=2215421 Jos de Kloe <josdekloe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josdekloe@xxxxxxxxx --- Comment #2 from Jos de Kloe <josdekloe@xxxxxxxxx> --- Hi Orion, thanks for working on this. Here are a first few remarks from a preliminary review. Issues: ======= - Package must not depend on deprecated() packages. Note: openssl1.1-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-2.0+'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ==>probably should be: "GPL-2.0-or-later" --Note that I don't see a license file in the source package. so "the packager SHOULD query upstream to include it." Browsing through the files in the sources directory I see several references to GPL v3 or later. Where did you find that the actual license is GPM v2 or later? - why did you include the %description fields twice? - regarding the %check section and the difficulty to install the tools from user perspective see my remarks in https://bugzilla.redhat.com/show_bug.cgi?id=2215420 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2215421 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202215421%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
